Re: [PATCH] Fix SIGSEGV in svn_path_is_uri_safe

kfogel@collab.net wrote:

>Okay, fix committed in revision 6654.
>
I seem to remember us having a policy that it's the caller's
responsibility to pass valid parameters to a function -- in this case,
the caller shouldn't call path_is_uri_safe at all if the parameter is
NULL. Has this policy changed?

>Thanks!
>
>-K
>
>magnus stahre <ms@xy.org> writes:
>
>
>>I found a bug introduced in r6638:
>>
>>$ svn co http://localhost
>>zsh: segmentation fault (core dumped) svn co http://localhost
>>
>>Gdb shows:
>>
>>Program received signal SIGSEGV, Segmentation fault.
>>0x7109b in svn_path_is_uri_safe (path=0x92a40 "http://localhost")
>> at subversion/libsvn_subr/path.c:813
>>813 for (i = 0; path[i]; i++)
>>
>>Log:
>>
>>* subversion/libsvn_subr/path.c
>> (svn_path_is_uri_safe): Don't iterate through slashes if there are no.
>>
>>

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org