Re: [PATCH] Issue #1074: Need a svnadmin command to verify that the repository is not corrupted

John Szakmeister <john@szakmeister.net> writes:

> 2) Use svn_fs__rep_contents_read_stream in my rep handler, and have the
> handler read the data in chunks and compute the checksum.
>
> I personally like method 2, but using that means that the checksum
> is actually getting checked twice: once inside of the read handler
> used for the stream, and then in my rep handler.

+1 on using this second method. (Sorry I didn't suggest it in my
mail.) As for the double verification, I see two routes to use:

   1. do the second verification, or

   2. change the docstring of svn_fs__rep_contents_read_stream() to
      promise that the checksum will be verified as the chunks are
      read. that way, you're coding a documented api, which will make
      it obvious why you didn't yourself do the checksumming.

My choice? Number 2 again.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 22 16:14:31 2003