Re: [PATCH] Issue #1074: Need a svnadmin command to verify that the repository is not corrupted

On Tuesday 22 July 2003 10:13 am, cmpilato@collab.net wrote:
> John Szakmeister <john@szakmeister.net> writes:

[snip]

> +1 on using this second method. (Sorry I didn't suggest it in my
> mail.) As for the double verification, I see two routes to use:
>
> 1. do the second verification, or
>
> 2. change the docstring of svn_fs__rep_contents_read_stream() to
> promise that the checksum will be verified as the chunks are
> read. that way, you're coding a documented api, which will make
> it obvious why you didn't yourself do the checksumming.
>
> My choice? Number 2 again.

I like method 2 as well. I'll get everything all wrapped up and submit a new
patch tomorrow.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 23 05:40:16 2003