[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1074: Need a svnadmin command to verify that the repository is not corrupted

From: John Szakmeister <john_at_szakmeister.net>
Date: 2003-07-22 09:45:16 CEST

Just a bit of an update... I went through and took a look at who is calling

It appears that only functions that were creating entries lists were calling
svn_fs__rep_contents... which makes me feel bad that I tried to use it in the
first place. :-(

So I see two solutions to this patch:

1) Add a function to rep-strings (like cmpilato originally suggested :-)
whose sole purpose is to verify the rep data by reading it in chunks and
updating the checksum.


2) Use svn_fs__rep_contents_read_stream in my rep handler, and have the
handler read the data in chunks and compute the checksum.

I personally like method 2, but using that means that the checksum is actually
getting checked twice: once inside of the read handler used for the stream,
and then in my rep handler.

What's the general feeling on this?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 22 09:44:56 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.