Shlomi Fish <shlomif@vipe.technion.ac.il> writes:
> On Fri, 17 Jul 2003 cmpilato@collab.net wrote:
>
> > Shlomi Fish <shlomif@vipe.technion.ac.il> writes:
> >
> > > > Honestly, the better thing to do would be to make ra->do_switch()
> > > > support this special case so we can lose the special code in
> > > > svn_client_switch() and avoid adding the same to all callers of this
> > > > interface. I began this work a while ago, but my patch-in-progress
> > > > was lost in an OS re-install. That said, I'd love to re-do this
> > > > change.
> > > >
> > >
> > > How is this change going to be performed? Which modules of the
> > > Subversion modules would we have to change to do this?
> >
> > You know, I actually misspoke above. I forgot that we have
> > ra->do_diff() (there was a time when diff used ra->do_switch). So,
> > actually, there are a couple of issues:
> >
> > - ra->do_switch() doesn't support the file case
> > - ra->do_diff() doesn't support the file case
> >
>
> Oh, OK. So I should still implement it in do_diff()?
I'm torn. I realize now that there are alot of things using
svn_repos_dir_delta() to effectively do file differences. So I'm
gonna backtrack, eat some crow, and take a closer look at your
original fix. As is, I don't think it's entirely correct. But with a
little bit of tweaking (perhaps, *gasp* another option to dir_delta),
it might just work (for switch, diff, etc.)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 18 17:11:49 2003