On Fri, 17 Jul 2003 cmpilato@collab.net wrote:
> Shlomi Fish <shlomif@vipe.technion.ac.il> writes:
>
> > > Honestly, the better thing to do would be to make ra->do_switch()
> > > support this special case so we can lose the special code in
> > > svn_client_switch() and avoid adding the same to all callers of this
> > > interface. I began this work a while ago, but my patch-in-progress
> > > was lost in an OS re-install. That said, I'd love to re-do this
> > > change.
> > >
> >
> > How is this change going to be performed? Which modules of the
> > Subversion modules would we have to change to do this?
>
> You know, I actually misspoke above. I forgot that we have
> ra->do_diff() (there was a time when diff used ra->do_switch). So,
> actually, there are a couple of issues:
>
> - ra->do_switch() doesn't support the file case
> - ra->do_diff() doesn't support the file case
>
Oh, OK. So I should still implement it in do_diff()?
And should I implement it in all of ra_local, ra_dav, and ra_svn? Or just
in svn_client? Or in ra_local and mod_dav_svn and svnserve? Where?
> > >From what I understand we have to:
> >
> > 1. Retrieve the source file.
> >
> > 2. Construct a txdelta stream between the source file and the target file.
> >
> > 3. Apply it between the source file and the target file on the local
> > machine.
> >
> > 4. Run svn_diff_do_diff().
> >
> > I know how to perform step #1, but I'm stumped on #2-#3.
>
> Or, you could just fetch the source file, fetch the target file, and
> run svn_diff_do_diff(). Forget the txdelta stuff altogether. :-)
>
:-)
This has a problem that if the difference between the files is not very
large, we will be wasting a lot of bandwidth in retrieving the second
file. By retrieving only the delta we many times can lower the bandwidth.
But it would be easier to implement.
Regards,
Shlomi Fish
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/
An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.
Falk Fish
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 18 12:49:00 2003