Re: [PATCH] Fix for Issue 1311

Shlomi Fish <shlomif@vipe.technion.ac.il> writes:

> > The diff URL URL code should be using the ra->get_file() interface to
> > grab the two files and perform the diff locally. See the special
> > "file" case of svn_client_switch().
> >
>
> So, you mean I should add a special test case in do_diff() for the case
> both URLs point to files? (in a manner similar to what happens in
> svn_client_switch()).

Honestly, the better thing to do would be to make ra->do_switch()
support this special case so we can lose the special code in
svn_client_switch() and avoid adding the same to all callers of this
interface. I began this work a while ago, but my patch-in-progress
was lost in an OS re-install. That said, I'd love to re-do this
change.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 16 17:47:23 2003