[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for Issue 1311

From: Shlomi Fish <shlomif_at_vipe.stud.technion.ac.il>
Date: 2003-07-16 08:53:35 CEST

On Tue, 15 Jul 2003 cmpilato@collab.net wrote:

> cmpilato@collab.net writes:
> > Shlomi Fish <shlomif@vipe.technion.ac.il> writes:
> >
> > > Hi!
> > >
> > > This is a one-line patch that fixes issue 1311:
> > >
> > > http://subversion.tigris.org/issues/show_bug.cgi?id=1311
> > >
> > > Namely, svn diff URL URL won't work when URLs are files.
> >
> > Did you run the test suite in full with this patch? I ask only
> > because, while I've not applied and tested it myself, I have my doubts
> > about its correctness.
> Okay. Now I have no more doubts about its correctness.
> I *know* it's incorrect. :-)
> You can't use svn_repos_dir_delta() to perform file diffs. Period.
> That's why it's called DIR-delta. And you might have noticed a
> certain amount of symmetry in the dir-delta code, where we do the same
> kinds of things on files and directories -- your patch breaks that
> symmetry, and I *guarantee* that this is something you don't do
> lightly.
> The diff URL URL code should be using the ra->get_file() interface to
> grab the two files and perform the diff locally. See the special
> "file" case of svn_client_switch().

So, you mean I should add a special test case in do_diff() for the case
both URLs point to files? (in a manner similar to what happens in


        Shlomi Fish

Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.

        Falk Fish

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 16 08:54:30 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.