Re: [PATCH] Fix for Issue 1311

On Wed, 16 Jul 2003 cmpilato@collab.net wrote:

> Shlomi Fish <shlomif@vipe.technion.ac.il> writes:
>
> > > The diff URL URL code should be using the ra->get_file() interface to
> > > grab the two files and perform the diff locally. See the special
> > > "file" case of svn_client_switch().
> > >
> >
> > So, you mean I should add a special test case in do_diff() for the case
> > both URLs point to files? (in a manner similar to what happens in
> > svn_client_switch()).
>
> Honestly, the better thing to do would be to make ra->do_switch()
> support this special case so we can lose the special code in
> svn_client_switch() and avoid adding the same to all callers of this
> interface. I began this work a while ago, but my patch-in-progress
> was lost in an OS re-install. That said, I'd love to re-do this
> change.
>

How is this change going to be performed? Which modules of the
Subversion modules would we have to change to do this?

From what I understand we have to:

1. Retrieve the source file.

2. Construct a txdelta stream between the source file and the target file.

3. Apply it between the source file and the target file on the local
machine.

4. Run svn_diff_do_diff().

I know how to perform step #1, but I'm stumped on #2-#3.

Regards,

        Shlomi Fish

----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.

        Falk Fish

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 17 23:39:57 2003