Please, shoot any feedback my way. If you have a copy of the re-worked patch
that would be a nice thing to look at too.
-John
On Tuesday 08 July 2003 02:07 am, cmpilato@collab.net wrote:
> John Szakmeister <john@szakmeister.net> writes:
> > Actually, I've been dying for some feedback about the patch.
>
> ...And I've been meaning to review it. I think I'll do so now. Ah,
> yes -- this is the one where you copied a bunch of functions from one
> module to another. I remember being bummed that we didn't just find a
> nice place to expose the original functions once, and use them in both
> places. Oh, and I see you overlooked (or ignored) the fact that
> svnlook/main.c uses the fn-space-paren style.
>
> But tonight, I'm feeling good, so I'll just rework your patch the way
> I would have liked to see it. You get a free one, on me. :-)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 8 11:31:45 2003