I wrote a regression test here after reading Philip's email. Would you like
it? All I did was compare svnlook's diff to svn's diff to make sure they
both did the same thing.
-John
On Tuesday 08 July 2003 04:20 am, cmpilato@collab.net wrote:
> cmpilato@collab.net writes:
> > John Szakmeister <john@szakmeister.net> writes:
> > > Actually, I've been dying for some feedback about the patch.
> >
> > ...And I've been meaning to review it. I think I'll do so now. Ah,
> > yes -- this is the one where you copied a bunch of functions from one
> > module to another. I remember being bummed that we didn't just find a
> > nice place to expose the original functions once, and use them in both
> > places. Oh, and I see you overlooked (or ignored) the fact that
> > svnlook/main.c uses the fn-space-paren style.
> >
> > But tonight, I'm feeling good, so I'll just rework your patch the way
> > I would have liked to see it. You get a free one, on me. :-)
>
> By the way, look for this commit tomorrow. Running tests now, but too
> sleepy to wait up for them. *yawn*
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 8 11:33:14 2003