[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 1241 - svnlook diff not printing property diffs

From: <cmpilato_at_collab.net>
Date: 2003-07-08 08:07:14 CEST

John Szakmeister <john@szakmeister.net> writes:

> Actually, I've been dying for some feedback about the patch.

...And I've been meaning to review it. I think I'll do so now. Ah,
yes -- this is the one where you copied a bunch of functions from one
module to another. I remember being bummed that we didn't just find a
nice place to expose the original functions once, and use them in both
places. Oh, and I see you overlooked (or ignored) the fact that
svnlook/main.c uses the fn-space-paren style.

But tonight, I'm feeling good, so I'll just rework your patch the way
I would have liked to see it. You get a free one, on me. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 8 08:07:04 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.