[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 1241 - svnlook diff not printing property diffs

From: John Szakmeister <john_at_szakmeister.net>
Date: 2003-07-08 01:05:32 CEST

Actually, I've been dying for some feedback about the patch. I have no
problem making a regression test if you don't mind helping me out a bit by
answering a couple of questions.

First, what's the best way to check the output of the svnlook diff command.
Is it enough that I check the output for the word 'Property' and make sure
that a property and value of my choice is in the output? Or would it be
better to compare it svn diff? I've already hacked my local copy of
svnlook_tests.py, I just need a little guidance on the preffered method of
validating the output.



On Monday 07 July 2003 01:12 pm, Philip Martin wrote:
> Shlomi Fish <shlomif@vipe.stud.technion.ac.il> writes:
> > Trying to find a bite-sized issue for me to fix, I ran across Issue 1241:
> >
> > http://subversion.tigris.org/issues/show_bug.cgi?id=1241
> >
> > In it the problem is that svnlook diff does not print property diffs.
> > However, it seems that John Szakmeister supplied a patch to it:
> >
> > http://www.contactor.se/~dast/svn/archive-2003-05/0757.shtml
> >
> > My question is: was the patch applied yet? If not, why not?
> One problem with the patch is that the link refers to the contactor
> archive, and the patch there is mangled. To apply the patch it would
> be necessary to track down a raw patch (from tigris, marc or gmane
> say), or to fix the patch by hand.
> In addition there is no regression test which means that whoever
> applies the patch is going to have to work out how to manually test it
> at the very least. Assuming it does work, without a regression test
> there is no guarantee that it will continue to work in the future.
> You say you are looking for a bite-sized issue to fix, well there is
> still work to be done on this one :)

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 8 01:05:35 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.