> From: cmpilato@collab.net [mailto:cmpilato@collab.net]
> Sent: Thursday, June 19, 2003 10:44 PM
> Christian Daudt <csd_ob@daudt.org> writes:
>
> > So someone else doesn't spend a morning trying to figure why they're getting
> > coredumps all of the sudden...
>
> Do I detect (in your patch) a note of sarcasm? :-)
>
> Dude, I'm sorry you wasted time looking at the wrong thing. But the
> clues are present. In the very libsvn_ra_dav code you pasted, there
> is a comment indicating that that section of code expects to get that
> name= attribute. Now, I dunno why you're seeing a case where this
> attribute isn't present, but if I could be so daring as to risk
> annoying you -- would you mind trying to solved *that* problem? I
> mean, if you have a Subversion server that's sending your client a
> bogus REPORT response, by golly we want to know about it.
In any case, we should not segfault on it. It is bad mojo if the server
can let the client crash (or the other way around) by bad data.
cvs is not hostile data proof and it's a pain in the butt.
> Please help us, and please don't be offended if your alternative patch
> falls by the wayside. (Our entire svn_string.c function set does not
> try to protect against NULL input, not just that one function).
In this case the location with the comment should do an actual check
and throw an appropiate error.
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 20 00:35:37 2003