[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] -std-c89 not required

From: <leif.eriksen_at_hpa.com.au>
Date: 2003-06-18 09:37:05 CEST

OK, so here is a new patch to remove it. I'd still like someone to generate
a configure from it (or tell me how to invoke autotool/conf to do it)

* configure.in
  -std=c89 can break some builds (especially some Solaris platforms), and is
not required in almost all cases.

(ismelorct.melb.hpa)/home/le99007/src> diff -u configure.in
--- configure.in Wed Jun 18 17:18:57 2003
+++ subversion-0.24.1/configure.in Mon Jun 16 23:20:04 2003
@@ -391,7 +391,7 @@
       if test "$GCC" = "yes"; then
         dnl SVN_DEBUG enables specific features for developer builds
         dnl AP_DEBUG enables specific (Apache) features for developer
- CFLAGS="$CFLAGS -Wpointer-arith -Wwrite-strings -Wshadow
+ CFLAGS="$CFLAGS -std=c89 -Wpointer-arith -Wwrite-strings -Wshadow

Leif Eriksen
HPA - IT Development
+61 3 9217 5545

-----Original Message-----
From: Justin Erenkrantz [mailto:justin@erenkrantz.com]
Sent: Wednesday, June 18, 2003 5:23 PM
To: Leif Eriksen; dev@subversion.tigris.org
Subject: RE: [PATCH] -std-c89 not supported

--On Wednesday, June 18, 2003 5:16 PM +1000 leif.eriksen@hpa.com.au wrote:

> Ah, so I'm confused now.
> 1. You said Sander was having an issue with Solaris, which made me think
> this was added to help him, but you say no.

No, he needed to remove it to compile. =) (Darn, Sander isn't awake yet.
hope I'm remembering correctly. Apologies if I'm not.)

> 2. When you say this whole thing should be yanked, do you mean the patch
> the directive to the compiler ?

I meant that -std=c89 shouldn't be passed to the compiler ever as APR
explicitly relies upon some semantics that may render the OS's includes
non-C89 compliant. Therefore, it isn't a check that we should turn on even
maintainer mode. -- justin

The contents of this e-mail and its attachments are confidential and intended
solely for the use of the individual or entity to whom they are
addressed. If you received this e-mail in error, please notify
the HPA Postmaster, postmaster@hpa.com.au, then delete
the e-mail.

This footnote also confirms that this e-mail message has been swept for
the presence of computer viruses by MimeSweeper. Before opening or
using any attachments, check them for viruses and defects.

Our liability is limited to resupplying any affected attachments.

HPA collects personal information to provide and market our services.
For more information about use, disclosure and access see our Privacy
Policy at www.hpa.com.au

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 18 09:38:48 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.