Re: [PATCH] -std-c89 not supported

On Wed, Jun 18, 2003 at 05:16:25PM +1000, leif.eriksen@hpa.com.au wrote:
> Ah, so I'm confused now.
>
> 1. You said Sander was having an issue with Solaris, which made me think
> this was added to help him, but you say no.
Sander was having trouble _because_ of this option.
> 2. When you say this whole thing should be yanked, do you mean the patch or
> the directive to the compiler ?
I think Justin meant that the std=c89 option should be yanded. The purpose of
the std=c89 option is that subversion wants to be portable to compilers and
platforms that only support c89, so this option gives us warnings or errors if
we use features that aren't in that standard (but may have been added later
like things in the c99 standard, or gcc extensions).

I personally think that we should keep it, but limit it to platforms we know
supports it. For now that may be linux. If people can test with this option
enabled on other platforms, and see if it is supported there, we can add them
at that time.

How does that sound?
> Leif Eriksen
> Developer
> HPA - IT Development
> +61 3 9217 5545
> leif.eriksen@hpa.com.au
>
> -----Original Message-----
> From: Justin Erenkrantz [mailto:justin@erenkrantz.com]
> Sent: Wednesday, June 18, 2003 4:44 PM
> To: Leif Eriksen; dev@subversion.tigris.org
> Subject: RE: [PATCH] -std-c89 not supported
>
>
> --On Wednesday, June 18, 2003 4:21 PM +1000 leif.eriksen@hpa.com.au wrote:
>
> > Perhaps it is best then to modify CFLAGS to use -std=c89 just for Solaris
> -
> > there is already a Solaris section in the configure.in. That ways, no
> other
> > platform gets except for possible problematic early gcc's on Solaris.
>
> Hmm? You've confused me now.
>
> Solaris's headers, when used in a POSIX-compliant program, do not conform to
>
> gcc's interpretation of C89.
>
> Therefore, -std=c89 can not be used on Solaris at all. As Sander recently
> found out, Subversion won't even compile. -- justin
>
>
>
> **********************************************************************
> IMPORTANT
> The contents of this e-mail and its attachments are confidential and intended
> solely for the use of the individual or entity to whom they are
> addressed. If you received this e-mail in error, please notify
> the HPA Postmaster, postmaster@hpa.com.au, then delete
> the e-mail.
>
> This footnote also confirms that this e-mail message has been swept for
> the presence of computer viruses by MimeSweeper. Before opening or
> using any attachments, check them for viruses and defects.
>
> Our liability is limited to resupplying any affected attachments.
>
> HPA collects personal information to provide and market our services.
> For more information about use, disclosure and access see our Privacy
> Policy at www.hpa.com.au
> **********************************************************************
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org