[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Tests

From: D.J. Heap <djheap_at_dhiprovo.com>
Date: 2003-06-17 01:28:17 CEST

From: Philip Martin [mailto:pm@localhost] On Behalf Of Philip Martin
>Oops, I misread your original message. I see now it's test 22 that
>fails, not test 21. Hmm, test 22 does
> was_dir = os.getcwd()
> os.chdir(...)
> if svntest.actions.run_and_verify_commit(...)
> os.chdir(was_dir)
> return 1
> os.chdir(was_dir)
>If the commit raises an exception then the chdir(was_dir) will not
>occur, which in turn will cause the second failure you see and means
>that all the later commit tests will not get run.
>This test, and possibly others that use chdir, may need to be
>converted to use try: finally:, or possibly the driver should ensure
>that the current working directory gets reset.

Ah, so that explains why the next test fails when this one does.

>> Yes, it could be another symptom of the filesystem race, I suppose.
>> haven't looked closely at the working copy and repo, but status and
>> commands work fine and show that the commit seemed to work fine. It
>> would help if I understood better what the test failure was saying --
>> it the working copy that does not match what was expected or is it
>> output from stdout or something else?
>I think the failure indicates that the commit command output contained
>a full path
> C:\some\path\to\iota
>while the test expected the output to have a path like
> iota
>I don't understand why the error is intermittent, I would expect it to
>occur every time, or not at all.

I see, commit prints different output if you commit outside the current
directory -- you get the absolute path. So, it seems the chdir to the
subdirectory didn't work (I'm not sure how to tell if it fails, should
Python throw an exception?); the commit did work and printed out the
file without the full path info. Since the directory is created right
above the chdir and it does exist in the working copy (looking at it
posthumously)), it is starting to look like it could be a/the filesystem
race. Perhaps I will have some luck recreating this one. I'm so


This email and any files transmitted with it are confidential
and intended solely for the use of the individual or entity to
whom they are addressed. If you have received this email
in error please notify the system manager.

This footnote also confirms that this email message has been
swept by MIMEsweeper for the presence of computer viruses.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 17 01:30:53 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.