[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC: Make apply_textdelta unconditional

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-06-02 10:23:52 CEST

On Wed, May 28, 2003 at 11:06:43AM -0400, Greg Hudson wrote:
> On Wed, 2003-05-28 at 01:36, kfogel@collab.net wrote:
> > I'd prefer for Greg Stein to have a chance to see the proposal. But
> > he's off at a convention right now, and may need a few days to catch
> > up with the list. Is your schedule such that you need to do this
> > change right away?

There are definitely two semantics at work here (two entities with control
over delta delivery), but I can also see how we end up tying them together
anyways. For example, in svnlook.py, we usually return a NULL window
handler, but we also happen to know that that is going to happen when we
drive the editor. Therefore, we turn off delta generation when calling
dir_delta.

Also note that this stuff will get wonked with the "change #6" where we flip
the control path in this. However, it doesn't seem like this change would
interfere with the API flip.

> Because of the incompatible ra_svn pipelining change, I'd like this to
> make it into 0.24, so that we don't break ra_svn compatibility for
> another two releases in a row. But apart from that, I can wait.

Dang. Where's that email about people not wanting the protocol to alter the
APIs in Subversion... hmm... :-) I also seem to recall a change to get
revnum info early (in a separate roundtrip(!)) because it couldn't happen
during a particular RA implementation's editor drive... :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 2 10:21:04 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.