Re: [PATCH] SVNServerSignature feature

On Fri, May 30, 2003 at 07:44:24AM -0700, Justin Erenkrantz wrote:
> --On Friday, May 30, 2003 11:48 AM +0100 Mukund <mukund@tessna.com> wrote:
>
> >ServerTokens does not do the same thing which SVNServerSignature
> >provides. Apache's ServerSignature is closer, but people will like
> >ServerSignature to be different from SVNServerSignature.
>
> Ah, sorry. I see.
>
> Well, IMHO, I think that mod_dav_svn should just emit the standard
> ServerSignature rather than emitting its own custom signature (i.e. call
> ap_psignature). And, the version info in ServerSignature is controlled by
> ServerTokens. I don't see the particular need for Subversion to do
> anything special here.

Agreed. I'd still want to see a little "Powered by Subversion" in there,
with the link to subversion.tigris.org. But the rest of the details could
easily come from ap_psignature().

> And, if you wanted to hide the version you have of Subversion, it's always
> in the Host: header if you don't have ServerTokens. So, hiding just the
> SVN signature without using ServerTokens is just pointless. -- justin

Server: response header, actually, but yup. It's gotta be removed from
there, and SVN can't do that. Thus, you'd have to use ServerTokens anyway,
so we may as well use that (via ap_psignature).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org