Re: svn commit: rev 6011 - trunk/subversion/clients/cmdline

On Tue, 2003-05-27 at 10:13, cmpilato@collab.net wrote:
> For what it's worth, I'm -0 on it, too, for every one of the same
> reasons. I only did it that way because I had some vague (perhaps
> broken) memory of that being the agreed-upon plan for subpool usage in
> the future.

Ah, this is why teachers are never supposed to write anything on a
chalkboard which is wrong; students will remember what they see and
forget the indication that it's wrong. In this case, Sander suggested
the broken idiom in a fit of misguided inspiration and immediately
retracted it. HACKING says:

         subpool = svn_pool_create(pool);
         for (i = 0; i < n; ++i)
         {
           svn_pool_clear(subpool);
           do_operation(..., subpool);
         }
         svn_pool_destroy(subpool);

I can fix up your commits, or you can; your call.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 27 16:27:28 2003