Re: svn commit: rev 6011 - trunk/subversion/clients/cmdline

Greg Hudson <ghudson@MIT.EDU> writes:

> On Thu, 2003-05-22 at 14:46, cmpilato@tigris.org wrote:
> > - for (i = 0; i < targets->nelts; i++)
> > + for (i = 0; i < targets->nelts; i++, svn_pool_clear (subpool))
>
> I'd like to register a -0 on this idiom. The contents of the
> parenthesized part of a for loop should be about the bounds of the loop,
> not about what the loop does. The svn_pool_clear() belongs at the
> beginning of the loop body.

For what it's worth, I'm -0 on it, too, for every one of the same
reasons. I only did it that way because I had some vague (perhaps
broken) memory of that being the agreed-upon plan for subpool usage in
the future.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 27 16:14:09 2003