[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 1241: svnlook not printing property diffs

From: <kfogel_at_collab.net>
Date: 2003-05-10 21:26:50 CEST

John Szakmeister <john@szakmeister.net> writes:
> First, I remember reading in the documentation of an example where you could
> store a JPEG thumbnail image in a property (it stands out in my mind, because
> I thought it was a neat idea). With that in mind, it would seem to me that
> we now have to be concerned about whether a property is text or binary,
> correct? I only ask because as I add in this change, it seems that in the
> case that we have binary files that differ, we simply say "binary files
> differ", or something to that effect.

I think for the first pass, you only need to implement the same
functionality that 'svn diff' has w.r.t. properties. I can't remember
whether it checks for binaryness or not (in these modern times, with
all sorts of text encodings running around, one has to wonder exactly
what binary data means anymoe)... But whatever behavior it has, that's
what svnlook should have too.

Now, improving that behavior is certainly an option, but let's treat
that as a separate issue; the fact that svnlook isn't showing property
diffs at all is the more basic bug.

> Also, I basically copied the code to do the property diffs straight from
> libsvn_client. It seems to me that this may be a common function to several
> libraries or command line clients (svnloon and svn). Should we look at
> adding a property diff function to libsvn_diff?

Sure -- if you see an opportunity for abstraction, and it looks
worthwhile, go for it.

> On that note, I need to put in a couple of comments and double check my
> formatting, and then I think I'll have a patch ready for submission tomorrow.

Looking forward to it!


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 10 22:09:29 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.