> I think for the first pass, you only need to implement the
> same functionality that 'svn diff' has w.r.t. properties. I
> can't remember whether it checks for binaryness or not (in
> these modern times, with all sorts of text encodings running
> around, one has to wonder exactly what binary data means
> anymoe)... But whatever behavior it has, that's what svnlook
> should have too.
It looks like the property diff code assumes that they're text based.
So I left it just like it was.
> Now, improving that behavior is certainly an option, but
> let's treat that as a separate issue; the fact that svnlook
> isn't showing property diffs at all is the more basic bug.
Done, see my patch email for the actual patch. :-)
> > Also, I basically copied the code to do the property diffs straight
> > from libsvn_client. It seems to me that this may be a common
> > function to several libraries or command line clients (svnloon and
svn).
> > Should we look at adding a property diff function to libsvn_diff?
>
> Sure -- if you see an opportunity for abstraction, and it
> looks worthwhile, go for it.
I'll take a closer look at doing that at some point in the near future
then. It seems to me that doing this would be great way to make sure
that 'svn diff' and 'svnlook diff' have the same output. And, I think
you get the added benefit that if anything else needs to do a diff and
the output needs to be changes, then there's only one place you need to
do it.
> > On that note, I need to put in a couple of comments and
> > double check my formatting, and then I think I'll have
> > a patch ready for submission tomorrow.
>
> Looking forward to it!
>
> -Karl
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
Thanks!
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 10 23:45:58 2003