Issue 1241: svnlook not printing property diffs

I decided to pick up a bite-sized task, and issue 1241 was it. :-) I've went
ahead a modified svnlook to print the property diffs, but I had a few
questions before I submitted a patch.

First, I remember reading in the documentation of an example where you could
store a JPEG thumbnail image in a property (it stands out in my mind, because
I thought it was a neat idea). With that in mind, it would seem to me that
we now have to be concerned about whether a property is text or binary,
correct? I only ask because as I add in this change, it seems that in the
case that we have binary files that differ, we simply say "binary files
differ", or something to that effect.

Also, I basically copied the code to do the property diffs straight from
libsvn_client. It seems to me that this may be a common function to several
libraries or command line clients (svnloon and svn). Should we look at
adding a property diff function to libsvn_diff?

On that note, I need to put in a couple of comments and double check my
formatting, and then I think I'll have a patch ready for submission tomorrow.

Thanks!

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 10 03:50:59 2003