Re: svn commit: rev 5814 - in trunk/subversion: libsvn_wc tests/clients/cmdline

On Mon, May 05, 2003 at 09:11:25PM -0500, cmpilato@collab.net wrote:
> the timing of this cleanup. The removal of missing items needs to
> happen at the same time as the bumping of the directory version
> number. When I originally came up with this solution, my idea was
> that this cleanup code would occur in two places:
>
> (1) the update_editor's close_dir() (which might require a new loggy
> operation)

I'm thinking that cleaning up missing/deleted dirs right *before* the
call to maybe_bump_dir_info might be the right thing?

No, wait, maybe_bump_dir_info can recurse up the directory tree... so
the cleanup needs to happen *inside* that loop?

[I am trying to find the right balance here between asking questions
and figuring stuff out for myself. If I make y'all do too much of my
research for me, I'm not saving you any time by taking this issue.
On the other hand, there are many cases where a core subversion
developer can tell me in 5 minutes what it would take me hours to
figure out for myself. I figure you probably know where the right
balance is better than I do, so I'm going to err on the side of asking
lots of questions for a while and you can tell me to go study the code
when you think that's appropriate.]

> (2) the global post-update revision bump (do_update_cleanup).

I think that r5814 covers place (2). Do you disagree?

-brian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 7 23:03:14 2003