Re: svn commit: rev 5814 - in trunk/subversion: libsvn_wc tests/clients/cmdline

Brian Denny <brian@briandenny.net> writes:

> I'm thinking that cleaning up missing/deleted dirs right *before* the
> call to maybe_bump_dir_info might be the right thing?
>
> No, wait, maybe_bump_dir_info can recurse up the directory tree... so
> the cleanup needs to happen *inside* that loop?

Hm... I'm not able to say without re-learning what that code does.
I'll try to take a look at this later and help you make a decision.

> [I am trying to find the right balance here between asking questions
> and figuring stuff out for myself. If I make y'all do too much of my
> research for me, I'm not saving you any time by taking this issue.
> On the other hand, there are many cases where a core subversion
> developer can tell me in 5 minutes what it would take me hours to
> figure out for myself. I figure you probably know where the right
> balance is better than I do, so I'm going to err on the side of asking
> lots of questions for a while and you can tell me to go study the code
> when you think that's appropriate.]

I am impressed by your honesty and consideration. Wow. +1 on marking
the "Brian Denny is clueless" issue as CLOSED/INVALID. :-) Seriously,
I think you're putting just the right amount of effort into this.

> > (2) the global post-update revision bump (do_update_cleanup).
>
> I think that r5814 covers place (2). Do you disagree?

Nope, from what I can tell, r5814 does indeed cover place (2).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 7 23:48:31 2003