Re: svn commit: rev 5814 - in trunk/subversion: libsvn_wc tests/clients/cmdline

Philip Martin <philip@codematters.co.uk> writes:

> bdenny@tigris.org writes:
>
> > Author: bdenny
> > Date: Mon May 5 16:40:25 2003
> > New Revision: 5814

[...]

> I still think the correct approach is to make the repository send the
> delete for the missing subdirectory. Update reports the missing
> directory to the repository, see the reporter->delete_path calls in
> libsvn_wc/adm_crawler.c:report_revisions. The repository delta
> generator should make better use of this information.

And I still disagree with you. The only problem with this patch is
the timing of this cleanup. The removal of missing items needs to
happen at the same time as the bumping of the directory version
number. When I originally came up with this solution, my idea was
that this cleanup code would occur in two places:

  (1) the update_editor's close_dir() (which might require a new loggy
      operation)
  (2) the global post-update revision bump (do_update_cleanup).

Though, I betcha my brain was moving faster than my fingers and I
failed to articulate that.

--
Now, part of my disgust with your insistance on making the repository
do this work is that I assumed (as did Brian Denny) that this change
would require modifications to svn_repos_dir_delta().  Those
modifications (at least the theory behind what Brian started doing
there) were completely I'm-gonna-minus-one-all-over-your-head wrong
in nature.
However, it occurs to me that perhaps the repos layer could provider a
second editor which is composed with the dir-delta editor, and whose
close_dir() function would perform the necessary checks and transmit
the extra editor->delete_entry() calls.
I dunno how that it would all turn out.  I still think the fix should
be client side.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org