[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5814 - in trunk/subversion: libsvn_wc tests/clients/cmdline

From: Brian Denny <brian_at_briandenny.net>
Date: 2003-05-06 04:54:00 CEST

On Mon, May 05, 2003 at 09:11:25PM -0500, cmpilato@collab.net wrote:
> And I still disagree with you. The only problem with this patch is
> the timing of this cleanup. The removal of missing items needs to
> happen at the same time as the bumping of the directory version
> number. When I originally came up with this solution, my idea was
> that this cleanup code would occur in two places:
> (1) the update_editor's close_dir() (which might require a new loggy
> operation)
> (2) the global post-update revision bump (do_update_cleanup).

in recursively_tweak_entries, we call svn_wc__tweak_entry with the new
revnum. is that what you're referring to in (2) above?

the update_editor's close_directory function calls maybe_bump_dir_info,
which looks like it also (potentially) changes the revnum? is that why
the removal of missing items needs to happen in the case of (1)?

why do we need to have these two separate places in the code that bump
the revnum?

(for that matter, i don't really understand the difference between
close_directory and close_edit -- i mean, i understand that close_edit
is only called once at the end, where close_directory might be called on
any directory being visited along the way... but why do some operations
have to happen at the one time, and others at the other?)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 6 04:51:19 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.