[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5671 - in trunk/subversion: libsvn_diff tests/libsvn_fs tests/libsvn_subr

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2003-04-18 21:09:25 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> If the warning reveals some problem with our code, like "int" being used
> with "apr_size_t" should be, then sure, we should fix it. But the issue
> is that we're using the type, not that unreleased-gcc spits out a
> warning.

Yep, that's what I was trying to say (only I didn't say it as clearly
as you).

So I think the issue can stay open, because gcc3.3 may be useful in
helping us find actual problems in our code. However, if no one gets
a chance to actually run a build with, we can certainly defer the
issue -- it's much less urgent now that we have svn_filesize_t. And
if someone does build with a prerelease GCC, and finds no meaningful
warnings, then we can close it.

> If the warning is bogus, then we certainly shouldn't make our code any
> less elegant in order to silence warnings from an unreleased compiler.
> (Warnings from a released compiler are a trickier issue.)

Agreed.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 18 21:54:21 2003

This is an archived mail posted to the Subversion Dev mailing list.