Re: svn commit: rev 5447 - trunk/subversion/libsvn_subr

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Branko <brane@xbc.nu> writes:
> > > }
> > > else
> > >- *valuep = default_value;
> > >+ {
> > >+ *valuep = default_value;
> > >+ }
> >
> > And yuck. Why add braces just because you can?
>
> Mike and I have both generally been adding braces whenever one case of
> a conditional has them and the other doesn't. This has been going on
> for some time, though we certainly aren't demanding that everyone do
> it -- let alone that you go back and do it to old code :-).

So long as things are consist within a single source file, the
presence of braces for single line blocks doesn't annoy me, but mixing
formatting changes with functional changes sure does.

If you're going to adopt this style universally, how about a single
commit?

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org