Re: svn commit: rev 5447 - trunk/subversion/libsvn_subr

Daniel Rall <dlr@finemaltcoding.com> writes:
> So long as things are consist within a single source file, the
> presence of braces for single line blocks doesn't annoy me, but mixing
> formatting changes with functional changes sure does.

Hmmm. <shrug> Something of a bikeshed, but yes, it's better to
separate functional from formatting changes -- especially if the
formatting changes are widespread. However, if someone happens to
tweak some indentation or bracing "along the way", in the area where
they're also making code changes, it doesn't bother me so much,
personally. As long as it's mentioned in the log message, and/or is
crystal clear in the diff.

However, separating them is a good idea in principle. I'll try to
make a point of it; or if I do it in the same commit, to at least
mention it in the log message.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 25 19:46:52 2003