Re: Splitting diff functionality out of libsvn_delta

"Sander Striker" <striker@apache.org> writes:

> Would anyone object me splitting the diff functionality out
> of libsvn_delta into its own lib; libsvn_diff?

One argument against doing this is that increasing the number of
shared libraries increases the startup time overhead incurred by
clients that use the libraries.

> Currently the namespace protection* already suggests this is
> the case.
>
> What needs to happen is basically:
>
> subversion/libsvn_delta/diff.c
> subversion/libsvn_delta/diff_file.c
>
> Move and expand to:
>
> subversion/libsvn_diff/diff.h
> subversion/libsvn_diff/diff.c
> subversion/libsvn_diff/diff3.c
> subversion/libsvn_diff/diff4.c
> subversion/libsvn_diff/lcs.c
> subversion/libsvn_diff/token.c
> subversion/libsvn_diff/util.c
> subversion/libsvn_diff/diff_file.c

A simple reorganisation like that will leave libsvn_diff depending on
libsvn_subr due to the svn_io_xxx calls. Is that what you intended?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org