Splitting diff functionality out of libsvn_delta

Hi,

Would anyone object me splitting the diff functionality out
of libsvn_delta into its own lib; libsvn_diff?

Currently the namespace protection* already suggests this is
the case.

What needs to happen is basically:

subversion/libsvn_delta/diff.c
subversion/libsvn_delta/diff_file.c

Move and expand to:

subversion/libsvn_diff/diff.h
subversion/libsvn_diff/diff.c
subversion/libsvn_diff/diff3.c
subversion/libsvn_diff/diff4.c
subversion/libsvn_diff/lcs.c
subversion/libsvn_diff/token.c
subversion/libsvn_diff/util.c
subversion/libsvn_diff/diff_file.c

Furthermore all tests related to diff in subversion/tests/libsvn_delta
move to subversion/tests/libsvn_diff.

subversion/tests/libsvn_diff/diff-test.c
subversion/tests/libsvn_diff/diff_test.dsp
subversion/tests/libsvn_diff/diff3-test.c
subversion/tests/libsvn_diff/diff3_test.dsp
subversion/tests/libsvn_diff/diff4-test.c
subversion/tests/libsvn_diff/diff4_test.dsp
subversion/tests/libsvn_diff/diff-diff3-test.c
subversion/tests/libsvn_diff/diff_diff3_test.dsp

And ofcourse build.conf needs a few tweaks. I've already done
this in my working copy and everything keeps working as is.
I feel that this split would make the diff code easier to grasp
and maintain.

Thoughts?

Sander

*) Which has some inconsistencies that I'll solve later on.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 17 20:46:14 2003