[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Specify external editor on command line for "svn propedit"?

From: Sander Roobol <phy_at_wanadoo.nl>
Date: 2003-03-11 14:40:34 CET

This patch has been filed as issue #1180.

Sander

On Sun, Mar 02, 2003 at 08:46:13PM +0000, Gareth McCaughan wrote:
> Suppose you have a property on a file that's something other than
> plain text: a thumbnail image, perhaps. Then to edit it you have to
> use "svn propget" and "svn propset"; you can't just use "svn
> propedit".
>
> Imagine that "svn propedit" takes a command-line option called
> "--editor-cmd", which specifies what external editor is to be called
> to edit the property. Then you can say
>
> svn propedit thumbnail whatever-file --editor-cmd image-editor
>
> or some variant thereof that actually works for your image file.
> I claim this would be a good thing, so I've implemented it; the
> attached diffs do what's needed. (Attached because the last
> time I sent a patch my mailer mangled it.)
>
> Comments?
>
> There was one decision that troubled me. Should the command-line
> option be called "--editor-cmd" (which might be useful for other
> Subversion subcommands in the future), or something more specific
> like "--property-editor-command"? Arguing for the former: brevity and
> the possibility that it will generalize better in the future. Arguing
> for the latter: mostly the fact that one *might* expect --editor-cmd
> to affect what editor is used for log messages. The patch as it stands
> uses --editor-cmd, but I'm prepared to be convinced that that's a
> mistake.
>
> --
> g
>

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 11 14:40:12 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.