[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Specify external editor on command line for "svn propedit"?

From: Gareth McCaughan <Gareth.McCaughan_at_pobox.com>
Date: 2003-03-02 21:46:13 CET

Suppose you have a property on a file that's something other than
plain text: a thumbnail image, perhaps. Then to edit it you have to
use "svn propget" and "svn propset"; you can't just use "svn
propedit".

Imagine that "svn propedit" takes a command-line option called
"--editor-cmd", which specifies what external editor is to be called
to edit the property. Then you can say

    svn propedit thumbnail whatever-file --editor-cmd image-editor

or some variant thereof that actually works for your image file.
I claim this would be a good thing, so I've implemented it; the
attached diffs do what's needed. (Attached because the last
time I sent a patch my mailer mangled it.)

Comments?

There was one decision that troubled me. Should the command-line
option be called "--editor-cmd" (which might be useful for other
Subversion subcommands in the future), or something more specific
like "--property-editor-command"? Arguing for the former: brevity and
the possibility that it will generalize better in the future. Arguing
for the latter: mostly the fact that one *might* expect --editor-cmd
to affect what editor is used for log messages. The patch as it stands
uses --editor-cmd, but I'm prepared to be convinced that that's a
mistake.

-- 
g


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Mar 2 21:47:31 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.