Re: [PATCH] Specify external editor on command line for "svn propedit"?

Branko ÄŒibej <brane@xbc.nu> writes:

> It feels like the command-line client is slowly transmogrifying into a
> full-blown GUI...but maybe that's just me.

I know the feeling.

> Apart from that, I don't see anything wrong with the idea.

Ditto. I don't use binary properties, but I can see this would be
useful if I did. Then again, I've only ever used the propedit command
when testing/debugging the command itself.

> >There was one decision that troubled me. Should the command-line
> >option be called "--editor-cmd" (which might be useful for other
> >Subversion subcommands in the future), or something more specific
> >like "--property-editor-command"?
> >
> Our policy is to make the option names as generic as possible (and
> sane). There's no reason not to use --editor-cmd for other purposes, not
> just svn propedit. On that note...

The problem is that 'svn propedit --revprop' could invoke *two*
editors, the first for the property and the second for the log
message. Given that we already have editor-cmd in the config file for
the log message editor it seems reasonable for --editor-cmd to refer
to the that editor. To be able to specify the property editor I don't
think we can avoid --property-editor-cmd.

> >+ {"editor-cmd", svn_cl__editor_cmd_opt, 1,
> >+ "Use \"ARG\" as external editor for all but log msgs"},
> >
> Why "for all but log msgs?" There's no reason why "svn commit", and
> other commands that accept an -m or -F for log messages, shouldn't
> accept --editor-cmd, too.

Agreed. Not to do so would be inconsistent with editor-cmd in the
confg file.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org