[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Specify external editor on command line for "svn propedit"?

From: Gareth McCaughan <Gareth.McCaughan_at_pobox.com>
Date: 2003-03-02 23:44:46 CET

[I proposed "svn propedit --editor-cmd /usr/local/bin/edit-whatever";
Brane wrote:]
> It feels like the command-line client is slowly transmogrifying
> into a full-blown GUI...but maybe that's just me. Apart from that,
> I don't see anything wrong with the idea.

I don't *remember* adding any GUI features in that patch.

> >There was one decision that troubled me. Should the command-line
> >option be called "--editor-cmd" (which might be useful for other
> >Subversion subcommands in the future), or something more specific
> >like "--property-editor-command"?
>
> Our policy is to make the option names as generic as possible (and
> sane). There's no reason not to use --editor-cmd for other
> purposes, not just svn propedit. On that note...
>
> >+ {"editor-cmd", svn_cl__editor_cmd_opt, 1,
> >+ "Use \"ARG\" as external editor for all but
> > log msgs"},
>
> Why "for all but log msgs?" There's no reason why "svn commit", and
> other commands that accept an -m or -F for log messages, shouldn't
> accept --editor-cmd, too.

Er, "for all but log msgs" because I'm a moron, of course.
I was thinking, goodness knows why, that when you did
"svn propedit" it might need you to give it a log message.
D'oh.

Attached is a revised version of the patch that adds --editor-cmd
to everything that uses an external editor.

-- 
g


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Mar 2 23:45:31 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.