Re: svn commit: rev 5001 - in trunk/subversion: include libsvn_wc libsvn_client libsvn_delta

On Sat, 2003-02-22 at 09:41, Philip Martin wrote:
> I don't think svn_types.h is correct. The "cancellation" editor
> doesn't really have anything to do with cancellation, it's simply an
> editor that calls a given function before dispatching to another
> editor. If you renamed it the "prefix" editor it would live quite
> naturally in svn_delta.h. It could even be generalised to have both
> prefix and suffix functions.

I'm not sure if making it more abstract will make our code clearer or
not. It's an interesting idea, though.

But it seems wrong to, having accepted the argument that the
cancellation editor should live in libsvn_delta, exclude it from
svn_delta.h and move it to a header file which doesn't even know the
nceessary types (svn_delta_editor_t).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 22 16:46:41 2003