[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5001 - in trunk/subversion: include libsvn_wc libsvn_client libsvn_delta

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-02-22 15:41:12 CET

Garrett Rooney <rooneg@electricjellyfish.net> writes:

> On Saturday, February 22, 2003, at 12:45 AM, Greg Stein wrote:
>
> > On Thu, Feb 20, 2003 at 08:58:44PM -0600, rooneg@tigris.org wrote:
> >>
> >> Added:
> >> trunk/subversion/include/svn_cancel.h
> >
> > Why the new header? We've got way too many as it is :-(
> >
> > I'd say add it to svn_delta.h or to svn_types.h.
>
> well, i didn't put it in svn_delta.h since i personally would never
> think to look for it there, since cancellation doesn't intrisically
> have anything to do with tree deltas (the cancellation editor does,
> but not the callback itself). svn_types.h sounds much more reasonable
> though, i just hadn't thought of that. i'll move it in there today.

I don't think svn_types.h is correct. The "cancellation" editor
doesn't really have anything to do with cancellation, it's simply an
editor that calls a given function before dispatching to another
editor. If you renamed it the "prefix" editor it would live quite
naturally in svn_delta.h. It could even be generalised to have both
prefix and suffix functions.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 22 15:41:54 2003

This is an archived mail posted to the Subversion Dev mailing list.