[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add reporter-set_path pool parameter

From: <cmpilato_at_collab.net>
Date: 2003-01-23 14:44:48 CET

Justin Erenkrantz jerenkrantz@apache.org writes:

 I believe the reporter-set_path function needs to grow a pool
 function for temporary memory allocations. One of the test cases
 dealt with doing an update after a commit with a WC dir that has 10k
 files in it. 'svn' used ~548MB and takes about 35sec. With this
 patch, we use ~13MB and 5sec.
 
 I apologize for not having a log message, but it's way past my bedtime
 and writing a log message would just be painful right now. Before
 committing, I promise to write a good log message (and fix up any
 doxygen bits). =) It also passes 'make check' here.
 
 What I'd like is a review that this is the 'right' approach before I
 proceed...

I believe the approach is correct. I didn't actually review the patch
(skimmed over it enough to see what your 'approach' was), but I think
you're on the right track. Optional: if you add the pool to set_path,
I would suggest adding it to the other reporter functions, too. It's
just the right thing to do.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:09:11 2006

This is an archived mail posted to the Subversion Dev mailing list.