Re: [PATCH] Add reporter-set_path pool parameter

Justin Erenkrantz wrote:

 I believe the reporter-set_path function needs to grow a pool
 function for temporary memory allocations. One of the test cases
 dealt with doing an update after a commit with a WC dir that has 10k
 files in it. 'svn' used ~548MB and takes about 35sec. With this
 patch, we use ~13MB and 5sec.

 I apologize for not having a log message, but it's way past my bedtime
 and writing a log message would just be painful right now. Before
 committing, I promise to write a good log message (and fix up any
 doxygen bits). =) It also passes 'make check' here.

 What I'd like is a review that this is the 'right' approach before I
 proceed...

Hmm, this looks good. However...

@@ -348,9 +357,10 @@
                                      notify_func, notify_baton,
                                      restore_files, recurse,
                                      traversal_info,
- subpool));
+ child_subpool));
         } /* end directory case */
 
+ svn_pool_clear (child_subpool);
     } /* end main entries loop */

Shouldn't we destroy child_subpool here?

-- 
Brane Čibej   brane_at_xbc.nu   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org