[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Add reporter-set_path pool parameter

From: <jerenkrantz_at_apache.org>
Date: 2003-01-23 11:40:14 CET

I believe the reporter-set_path function needs to grow a pool
function for temporary memory allocations. One of the test cases
dealt with doing an update after a commit with a WC dir that has 10k
files in it. 'svn' used ~548MB and takes about 35sec. With this
patch, we use ~13MB and 5sec.

I apologize for not having a log message, but it's way past my
bedtime and writing a log message would just be painful right now.
Before committing, I promise to write a good log message (and fix up
any doxygen bits). =) It also passes 'make check' here.

What I'd like is a review that this is the 'right' approach before I
proceed...

Reproduction case:

svnadmin create repo
svn co file://`pwd`/repo wc
pushd wc
for file1 in 0 1 2 3 4 5 6 7 8 9; do
  for file2 in 0 1 2 3 4 5 6 7 8 9; do
    for file3 in 0 1 2 3 4 5 6 7 8 9; do
      echo too-slow $file1.$file2.$file3
    done;
  done;
done
svn add ?.?.?
svn commit -m stuff
echo Sleeping 3 seconds before calling update
sleep 3
svn update

---
The final 'svn update' will grow ridiculously large, but it'll work. 
With the patch applied, the memory usage seems constant and much 
smaller.
Can anyone come up with a reason we shouldn't apply this?  Is there 
another way?
I'm attaching the patch in the hopes that my mailer doesn't munge it 
and wrap long lines.  *sigh*  -- justin


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Oct 14 02:09:05 2006

This is an archived mail posted to the Subversion Dev mailing list.