[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4512 - trunk/subversion/libsvn_ra_svn

From: <rooneg_at_electricjellyfish.net>
Date: 2003-01-23 01:12:52 CET

On Wednesday, January 22, 2003, at 07:09 PM, Greg Hudson wrote:

 On Wed, 2003-01-22 at 19:05, Greg Hudson wrote:
 On Wed, 2003-01-22 at 18:37, rooneg@tigris.org wrote:
 + tunnel_agent = NULL;
    SVN_ERR( find_tunnel_agent(hostname, tunnel_agent, pool) );
    if (tunnel_agent)

 Uh, that's completely unnecessary. Does some compiler actually give a
 warning about that?

 Actually, I misread. But find_tunnel_agent should probably be doing
 the
 setting to NULL, rather than setting tunnel_agent in some (non-error)
 cases and not in others.

ok, i'll make the change.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:07:55 2006

This is an archived mail posted to the Subversion Dev mailing list.