[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4512 - trunk/subversion/libsvn_ra_svn

From: <epg_at_pretzelnet.org>
Date: 2003-01-23 01:14:11 CET

Greg Hudson ghudson@MIT.EDU writes:

 On Wed, 2003-01-22 at 18:37, rooneg@tigris.org wrote:
  + tunnel_agent = NULL;
     SVN_ERR( find_tunnel_agent(hostname, tunnel_agent, pool) );
     if (tunnel_agent)
 
 Uh, that's completely unnecessary. Does some compiler actually give a
 warning about that?

If my compiler warned about it i wouldn't have needed a second
patch. What happened was it actually blew up at run-time when i
tried it without anything in .subversion/servers. Surprised, i
walked through it with gdb and found out that in that case
tunnel_agent had a random value, said Oh shit and submitted the
second patch.

It is necessary.

--
Eric Gillespie * epg@pretzelnet.org

Build a fire for a man, and he'll be warm for a day. Set a man on
fire, and he'll be warm for the rest of his life. -Terry Pratchett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:07:57 2006

This is an archived mail posted to the Subversion Dev mailing list.