[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4455 - trunk/subversion/libsvn_ra_dav

From: <gstein_at_lyra.org>
Date: 2003-01-20 11:44:38 CET

On Mon, Jan 20, 2003 at 04:06:15AM -0600, gstein@tigris.org wrote:
 Author: gstein
 Date: 2003-01-20 04:05:50 -0600 (Mon, 20 Jan 2003)
 New Revision: 4455
 
 Modified:
    trunk/subversion/libsvn_ra_dav/fetch.c
 Log:
 svn_ra_dav__get_one_prop() has a deep bug in it. For the 0.17 release,
 we'll just tweak around it.

The deep bug is that __get_one_prop() calls the underlying __get_props()
function which sets up both an XML processor and Neon's standard property
handling. It uses the XML processor to grab href contents; meanwhile, it
uses Neon's processing for other properties.

The problem is that the XML-based handling can't figure out that a property
was 404 (Not Found). It grabs the value which is simply the empty string
(the property gets named in the 404 area, and the naming implies the empty
value).

I believe the solution is to figure out why the XML processor is being used
for non-href properties. I can simply turn them off, but that is a bit more
risky than the fix I installed into fetch.c.

[ btw, the symptom of this bug was that a new client could not fetch files
  off an old server ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:02:17 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.