[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 1084] - [PATCH] ra_svn move/copy bug

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2003-01-15 17:59:35 CET

Eric Gillespie <epg@pretzelnet.org> writes:
> That's similar to what i originally thought. I thought it must
> be a bug that a NULL ever made it to check_path. But i looked in
> repos_to_repos_copy, and it treats NULL as if it is a perfectly
> reasonable value to have (by doing some manipulation on the path
> if it isn't NULL and not signalling an error if it is). I also
> looked at ra_dav's check_path and see that it also treats NULL as
> acceptable. Based on that evidence i concluded that it is legal
> to pass a NULL to check_path.
>
> If that is deemed incorrect, i can provide a patch fixing all
> check_path callers.

The latter sounds better to me too (conservatively, of course -- that
is, if the path "shouldn't" be null in the caller anyway, then add no
check). Thanks, Eric.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 15 18:45:44 2003

This is an archived mail posted to the Subversion Dev mailing list.