[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 1084] - [PATCH] ra_svn move/copy bug

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2003-01-15 18:00:20 CET

issues@subversion.tigris.org writes:

> This is not a correct patch by itself. check_path should not accept a
> null path argument unless include/svn_ra.h documents that that is
> okay. And why should it be okay to pass a null path? (For
> consistency with other ra_lib functions, perhaps, but I actually hope
> to tighten those contracts before 1.0 so that null path argments
> aren't okay there either.)
>
> Anyway, either include/svn_ra.h should be modified so that check_path
> is documented as accepting a null path, which I'm not crazy about but
> can accept, or the caller should be fixed instead of ra_svn.

That's similar to what i originally thought. I thought it must
be a bug that a NULL ever made it to check_path. But i looked in
repos_to_repos_copy, and it treats NULL as if it is a perfectly
reasonable value to have (by doing some manipulation on the path
if it isn't NULL and not signalling an error if it is). I also
looked at ra_dav's check_path and see that it also treats NULL as
acceptable. Based on that evidence i concluded that it is legal
to pass a NULL to check_path.

If that is deemed incorrect, i can provide a patch fixing all
check_path callers.

--
Eric Gillespie <*> epg@pretzelnet.org

Build a fire for a man, and he'll be warm for a day. Set a man on
fire, and he'll be warm for the rest of his life. -Terry Pratchett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 15 18:01:10 2003

This is an archived mail posted to the Subversion Dev mailing list.