[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] gen-make-modular.patch

From: Brandon Ehle <behle_at_pipedreaminteractive.com>
Date: 2002-12-15 22:13:35 CET

>
>
>>- def __init__(self, fname, verfname, oname):
>>+ def __init__(self, fname, verfname, oname=None):
>> gen_base.GeneratorBase.__init__(self, fname, verfname)
>>
>>+ if not oname:
>>+ oname = os.path.splitext(os.path.basename(fname))[0] + '-outputs.mk'
>>+
>> self.ofile = open(oname, 'w')
>> self.ofile.write('# DO NOT EDIT -- AUTOMATICALLY GENERATED\n\n')
>>
>>
>>
>Why are you doing this? It's not the module's job to guess the output
>file name; that should be done by the output script, the way it was done
>before.
>
>
I fail to see the point of this, only the module know what its
outputing, if we drop this in the driver script then the we have to
special case every module in the driver.

>[etc.]
>
>I don't like this change at all. You're mixing apples and oranges.
>gen-make.py generates makefiles, not .dsp's. The requirements are
>substantially different; you're complicating the driver script
>needlessly. The dsp generator should have its own driver script.
>
>
So you'd rather have about 8 different gen-*.py scripts in the toplevel
directory (once all the windows project file modes are done)?

Please note that some of the gen-*.py scripts for windows will consist of:

gen-msvc-dsp.py
gen-msvc-nmake.py
gen-mingw.py
gen-vcnet-vcproj.py
gen-vcnet-nmake.py
gen-bcpp-bpr.py
gen-bcpp-make.py

You'd rather have all those scripts sitting in the toplevel directory in
addition to gen-make.py, or would you rather have one gen-make.py script
that can invoke any of the above (and you can even pass it the "all"
parameter to generate everything)?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 15 19:10:48 2002

This is an archived mail posted to the Subversion Dev mailing list.