Re: [PATCH] gen-make-modular.patch

Brandon Ehle wrote:

> So you'd rather have about 8 different gen-*.py scripts in the
> toplevel directory (once all the windows project file modes are done)?
>
> Please note that some of the gen-*.py scripts for windows will consist
> of:
>
> gen-msvc-dsp.py
> gen-msvc-nmake.py
> gen-mingw.py
> gen-vcnet-vcproj.py
> gen-vcnet-nmake.py
> gen-bcpp-bpr.py
> gen-bcpp-make.py

Heh. Some drivers will be closely related -- I submit that MinGW would
use makefiles just like Unix, and those would of course be generated by
get-make.py. The .dsp and .vcproj generators should be closely related
too, I expect. And I see no reason to generate both project files and
makefiles; one or the other, but both is overkill.

> You'd rather have all those scripts sitting in the toplevel directory
> in addition to gen-make.py,

No, I'd rather have all those scripts somewhere in build/, where they
belong.

> or would you rather have one gen-make.py script that can invoke any of
> the above (and you can even pass it the "all" parameter to generate
> everything)?

I would not. The Windows scripts have to handle things like the location
of httpd sources, the location of apr/apr-util/apr-iconv and neon, and
BDB... in short, a lot of things that configure takes care of on Unix. I
see no read on to put that logic into gen-make.py, because it clearly
doesn't belong there.

Keep things modular. One huge do-it-all script is a pain to maintain.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org