[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3983 - in trunk: . subversion/include subversion/libsvn_ra_svn subversion/svnserve

From: <brane_at_xbc.nu>
Date: 2002-12-04 18:00:58 CET

Quoting Greg Hudson <ghudson@MIT.EDU>:

> Thanks. A few small complaints:
>
> On Wed, 2002-12-04 at 01:09, brane@tigris.org wrote:
> > -- "log" happens to be a standard C function; for consistency all
> > the svnserve vtable function names got a prefix.
>
> I had a convention for this, which was to add "_cmd" to just the symbols
> which had conflicts. (switch_cmd was the only one so far.) Calling
> them ra_svn_foo means the server functions have the same names as the
> client functions, which can be inconvenient when setting breakpoints.

Ah, O.K. The other RA libs use a common prefix on the vtable functions, so in
fact to be consistent the prefix should be svn_ra_svn__ (even on static
functions). Personally I'd rather see those names prefixed, so that the purpose
of the functions is obvious from the names. I'd also prefer to have the function
names (after the prefix) the same as in ra_dav and ra_local.

 
> > -static svn_error_t *get_latest_rev(svn_ra_svn_conn_t *conn, apr_pool_t *pool,
> > - apr_array_header_t *params, void *baton)
> > +static svn_error_t *
> > +ra_svn_get_latest_rev(svn_ra_svn_conn_t *conn, apr_pool_t *pool,
> > + apr_array_header_t *params, void *baton)
>
> Unless we have a tree-wide style policy on this point, I'd prefer if
> you wouldn't reformat these function declarations.

As a matter of fact, we _do_ have a style policy, it just so happens that both
Gregs tend to ignore it. :-)
Seruously: I reformatted them because the names got longer and the declarations
wouldn't fit in 80 columns any more.

    Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 4 18:01:52 2002

This is an archived mail posted to the Subversion Dev mailing list.